refactor: migrate tests to Vitest + TS #1202
Open
+10,359
−9,886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-ts-refactor-redone
Co-authored-by: j-k <dev@j-k.io> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: j-k <dev@j-k.io> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: j-k <dev@j-k.io> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: j-k <dev@j-k.io> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
…om/jescalada/git-proxy into 1150-vitest-migration-from-service
jescalada
force-pushed
the
1150-vitest-migration-from-service
branch
from
e46cfac to
4b9b89b
Compare
jescalada
force-pushed
the
1150-vitest-migration-from-service
branch
from
4b9b89b to
61d349f
Compare
Contributor
Author
|
@kriswest I think this is ready for another look - hoping to get the v2 release ready soon! |
kriswest
reviewed
Nov 28, 2025
kriswest
approved these changes
Nov 28, 2025
Contributor
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
LGTM - thanks for the logging cleanup and email comparison fix. Still had a couple of type overrides I wasn't sure you needed... worth leaving a comment if it is needed.
The only lingering issue I see is the proxy tests. Logging errors on start/stop might be worth doing (as it appears not to have stopped...). If that doesn't turn up the answer then it should go on an issue so we can get this merged.
Contributor
Author
|
@kriswest Thanks for taking another look! Hoping it's ready to go now 😃 |
kriswest
reviewed
Nov 28, 2025
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
kriswest
reviewed
Nov 28, 2025
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1150, built on top of #1166.
Not all tests were perfectly refactored from Chai/Mocha -> Vitest. Some required partial or total rewriting to get them to play nice.
Some tests, specifically the proxy-related tests (
proxy.test.ts,testProxy.test.tsand most importantlytestProxyRoute.test.ts) have been very problematic for some reason - the tests intestPush.test.tsseem to fail in the CI when some of the proxy tests execute prior. They fail on the first execution locally, and then pass without issue (maybe a caching/cleanup problem).Coverage has dropped somewhat to 80.5%, but we should see an increase after removing unused/untested code such as plugin stuff.
Note that the CI is failing due to the new Blue Oak license.